Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor][Query] Typing updates #28618

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Feb 2, 2023

This addresses some apiview comments.

  • Removed class attributes and docs for LogsBatchQuery as these don't need to be exposed.
  • Changed typing for several kwargs to be Optional.
  • Fixed incorrect typing for timeseries in Metric.
  • Change MutableMapping to Mapping for JSON response types.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-monitor-query

@pvaneck pvaneck force-pushed the query-apiview-feb branch 3 times, most recently from a698f99 to eaefa97 Compare February 6, 2023 21:03
@pvaneck pvaneck requested a review from annatisch February 6, 2023 21:09
This addresses some apieview comments.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck merged commit 9c481c9 into Azure:main Feb 7, 2023
@pvaneck pvaneck deleted the query-apiview-feb branch February 7, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants